Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from ryu to os_ken. #3975

Merged
merged 2 commits into from
Dec 1, 2021
Merged

switch from ryu to os_ken. #3975

merged 2 commits into from
Dec 1, 2021

Conversation

anarkiwi
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #3975 (c5ff9a6) into master (60a4d4b) will not change coverage.
The diff coverage is 97.78%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3975   +/-   ##
=======================================
  Coverage   92.49%   92.49%           
=======================================
  Files          47       47           
  Lines        8865     8865           
=======================================
  Hits         8199     8199           
  Misses        666      666           
Impacted Files Coverage Δ
faucet/__main__.py 85.00% <75.00%> (ø)
faucet/acl.py 93.87% <100.00%> (ø)
faucet/faucet.py 74.87% <100.00%> (ø)
faucet/faucet_bgp.py 89.12% <100.00%> (ø)
faucet/faucet_dot1x.py 92.31% <100.00%> (ø)
faucet/faucet_event.py 60.00% <100.00%> (ø)
faucet/gauge.py 82.93% <100.00%> (ø)
faucet/gauge_pollers.py 92.41% <100.00%> (ø)
faucet/prom_client.py 97.78% <100.00%> (ø)
faucet/valve_of.py 94.47% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60a4d4b...c5ff9a6. Read the comment docs.

@anarkiwi
Copy link
Member Author

Passes OK, but requires a chewie and beka release to allow for most recent eventlet/msgpack which os_ken provide.

@gizmoguy
Copy link
Member

New releases can be arranged for both of those, doing a chewie release involved building a new docker image so wondering if before we do a chewie release we upgrade the alpine used for the faucet/base & faucet/python3 images? Do we have a preferred alpine release? Looks like supported releases are v3.12 and v3.13 (both with python3.8, but v3.13 will trigger #3853) and v3.14 with python3.9.

@anarkiwi
Copy link
Member Author

New releases can be arranged for both of those, doing a chewie release involved building a new docker image so wondering if before we do a chewie release we upgrade the alpine used for the faucet/base & faucet/python3 images? Do we have a preferred alpine release? Looks like supported releases are v3.12 and v3.13 (both with python3.8, but v3.13 will trigger #3853) and v3.14 with python3.9.

I propose v3.14, I've done extensive testing with this as a base.

@gizmoguy
Copy link
Member

Okay I'll work on getting 3.14 versions of our docker images out before the dev call tomorrow.

Btw alpine 3.15 just landed a couple days ago, which also uses python3.9 which we can look to upgrade to in future once we've been able to do some testing with it.

In the meantime, I've now packaged os-ken + eventlet + msgpack for apt: https://github.com/faucetsdn/python3-os-ken/runs/4361958898

@anarkiwi anarkiwi marked this pull request as ready for review December 1, 2021 02:15
@anarkiwi anarkiwi merged commit 5486eb5 into faucetsdn:master Dec 1, 2021
@anarkiwi anarkiwi deleted the osken branch December 1, 2021 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants