Update to new faucet_config_hash_info label format #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 19, 2019
Update faucet_config_hash_info label format for compatibility with faucetagent
faucetsdn/faucet#2911
Merged
lantz
changed the title
lantz
force-pushed
the
promclient
branch
2 times, most recently
from
3ebe8f9
to
02ea3cf
Compare
The new format is:
{config_files='file1,file2', hashes='hash1,hash2'}
However, the agent only supports one hash file atm.
Also: switch to using prometheus_client.parser
Fixes faucetsdn#12
anarkiwi
approved these changes
Apr 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new format is:
{config_files='file1,file2', hashes='hash1,hash2'}The agent currently only supports one config file/hash, but potentially could support multiple files (i.e. includes) in the future.
Also: switch to using
prometheus_client.parserDepends on faucetsdn/faucet#2911 (merged)
Fixes #12