Functionality-neutral refactor (mostly lint fixes) #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnrandolph
approved these changes
Mar 17, 2022
| public class PubSubClient { | ||
|
|
||
| private final static Logger LOG = LoggerFactory.getLogger(PubSubClient.class); | ||
| private static final Logger LOG = LoggerFactory.getLogger(PubSubClient.class); |
| @@ -31,7 +31,7 @@ sourceSets { | |||
|
|
|||
| checkstyle { | |||
| ignoreFailures = false | |||
| maxWarnings = 150 | |||
| maxWarnings = 66 | |||
There was a problem hiding this comment.
What is this, threshold of current warnings?
|
What does "NOP: oof" mean?
Yes, the maxWarnings is the threshold... idea is that it should only go
down as we either improve things or not go up as we add things!
…On Thu, Mar 17, 2022 at 9:59 AM John R ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In pubber/src/main/java/daq/pubber/PubSubClient.java
<#271 (comment)>:
> public class PubSubClient {
- private final static Logger LOG = LoggerFactory.getLogger(PubSubClient.class);
+ private static final Logger LOG = LoggerFactory.getLogger(PubSubClient.class);
NOP: oof
------------------------------
In validator/build.gradle
<#271 (comment)>:
> @@ -31,7 +31,7 @@ sourceSets {
checkstyle {
ignoreFailures = false
- maxWarnings = 150
+ maxWarnings = 66
What is this, threshold of current warnings?
—
Reply to this email directly, view it on GitHub
<#271 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIEPD3OKFG4KLBWE4PPVSTVANQGVANCNFSM5Q4TPR7A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.