Fix subType streaming validator errors #272
Conversation
| - name: validation logs | ||
| fgrep 'RESULT ' /tmp/test_log.txt | sed -e 's/.*sequencer RESULT/RESULT/' > /tmp/sequencer.out | ||
| diff -u /tmp/sequencer.out etc/sequencer.out && echo No output diff detected. | ||
| - name: device ouput logs |
There was a problem hiding this comment.
I'll fold this into another PR
|
|
||
| PUBBER_OUT=pubber.out | ||
|
|
||
| pids=`ps ax | fgrep pubber | fgrep java | awk '{print $1}'` |
There was a problem hiding this comment.
This feels heavy handed? Is this to strengthen repeated runs of this test, or to stop interference with other running tests?
There was a problem hiding this comment.
Yes -- but I'd defer any of those changes to something separate from the basic functionality. I agree with your comments, but I wouldn't want to get into it as part of this PR!
| cp udmi_site_model/devices/AHU-1/rsa_private.pkcs8 \ | ||
| udmi_site_model/gcp_reflect_key.pkcs8 | ||
|
|
||
| bin/validator $site_path $project_id & |
There was a problem hiding this comment.
Should we trap on exit of validator so we know if it exits while running pubber?
There was a problem hiding this comment.
Maybe-- the code as it stands checks the output of what validator does, so it doesn't matter if it exits prematurely or not... Either the generated output is correct or not.
|
|
||
| echo Waiting for system to run for a bit... | ||
| sleep 30 | ||
|
|
There was a problem hiding this comment.
If this becomes more cumbersome, or we get unpredictable test results, I suggest using the shell's jobs command to focus our kill usage
For example:
jobs -x kill %pubber
jobs -x kill %validator
Although I'm not sure whether the shell would see either java or pubber/validator
|
|
||
| outfiles=`find out/devices -name \*.out` || true | ||
| echo Found .out files $outfiles, copying to /tmp/validator.out | ||
| more $outfiles > /tmp/validator.out || true |
There was a problem hiding this comment.
more includes the filename in the output, so it's convenient for logging since you get more context, rather than just a bunch of stuff combined together
| echo Waiting for system to run for a bit... | ||
| sleep 30 | ||
|
|
||
| pids=`ps ax | fgrep pubber | fgrep java | awk '{print $1}'` |
There was a problem hiding this comment.
Or at least pids=`pgrep pubber` ?
No description provided.