Deploy UDMI cloud functions with gcloud #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Firebase SDK bits also need to be removed or wrapped into some error handling for this to work, otherwise there are errors which prevent execution |
|
But otherwise, running the script to deploy worked well |
|
I'm trying to keep the scope of the bug tractable for now... This is just
the first part (deploying the functions with gcloud) -- doesn't
actually imply that they will work. Maybe this was meant to be "deploy to a
project without firebase enabled"? That's something very different...
…On Thu, Mar 17, 2022 at 9:49 AM Noureddine ***@***.***> wrote:
But otherwise, running the script to deploy worked well
—
Reply to this email directly, view it on GitHub
<#275 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIEPD4VBBVWPGWT5G4KTVLVANPBBANCNFSM5Q7HCF7Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
johnrandolph
approved these changes
Mar 18, 2022
| PUBSUB_FUNCTIONS="udmi_target udmi_state udmi_config udmi_reflect" | ||
| for func in $PUBSUB_FUNCTIONS; do | ||
| echo Deploying pubsub-trigger function $func... | ||
| gcloud functions deploy $func --trigger-topic=$func --runtime=$RUNTIME --project=$PROJECT --source=$SOURCE |
There was a problem hiding this comment.
I'm fine with this for now but is there a way to make one atomic deploy, and/or do we want to stop deploying if any one deploy fails?
|
I think "terraform" is the answer to the atomic deploy and/or error
handling. I'm not sure trying to do that through gcloud directly would ever
be robust enough!
…On Fri, Mar 18, 2022 at 7:44 AM John R ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In dashboard/deploy_dashboard_gcloud
<#275 (comment)>:
> +cd $ROOT/dashboard
+
+PROJECT=$1
+shift
+
+RUNTIME=nodejs12
+SOURCE=functions/
+
+version=`git describe --dirty`
+echo Deploying version $version to $PROJECT
+echo "const udmi_deploy_version = '$version';" > public/deploy_version.js
+
+PUBSUB_FUNCTIONS="udmi_target udmi_state udmi_config udmi_reflect"
+for func in $PUBSUB_FUNCTIONS; do
+ echo Deploying pubsub-trigger function $func...
+ gcloud functions deploy $func --trigger-topic=$func --runtime=$RUNTIME --project=$PROJECT --source=$SOURCE
I'm fine with this for now but is there a way to make one atomic deploy,
and/or do we want to stop deploying if any one deploy fails?
—
Reply to this email directly, view it on GitHub
<#275 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIEPD6KAOLA2QNIH2I6TE3VASJEFANCNFSM5Q7HCF7Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
lgtm
…On Fri, Mar 18, 2022 at 10:47 AM Trevor ***@***.***> wrote:
I think "terraform" is the answer to the atomic deploy and/or error
handling. I'm not sure trying to do that through gcloud directly would ever
be robust enough!
On Fri, Mar 18, 2022 at 7:44 AM John R ***@***.***> wrote:
> ***@***.**** approved this pull request.
> ------------------------------
>
> In dashboard/deploy_dashboard_gcloud
> <#275 (comment)>:
>
> > +cd $ROOT/dashboard
> +
> +PROJECT=$1
> +shift
> +
> +RUNTIME=nodejs12
> +SOURCE=functions/
> +
> +version=`git describe --dirty`
> +echo Deploying version $version to $PROJECT
> +echo "const udmi_deploy_version = '$version';" >
public/deploy_version.js
> +
> +PUBSUB_FUNCTIONS="udmi_target udmi_state udmi_config udmi_reflect"
> +for func in $PUBSUB_FUNCTIONS; do
> + echo Deploying pubsub-trigger function $func...
> + gcloud functions deploy $func --trigger-topic=$func --runtime=$RUNTIME
--project=$PROJECT --source=$SOURCE
>
> I'm fine with this for now but is there a way to make one atomic deploy,
> and/or do we want to stop deploying if any one deploy fails?
>
> —
> Reply to this email directly, view it on GitHub
> <#275 (review)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AAIEPD6KAOLA2QNIH2I6TE3VASJEFANCNFSM5Q7HCF7Q
>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
>
> or Android
> <
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
>.
>
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#275 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALMRW5OOZOVBDLOWDDQAL3VASJQLANCNFSM5Q7HCF7Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you commented.Message ID:
***@***.***>
--
John Randolph -- Google NYC
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.