Add site_defaults.json in site model directory, which can supply default values to all Metadata. #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evel can have default settings for the entire set.
site_defaults.json into device Metadata if the values are not present.
…o site_wide_defaults
site_defaults.json is loaded with the metadata schema.
the latter of which existed to post-process readMetadata() output in an earlier version.
produce default configs.
which was not discussed.
grafnu
reviewed
Apr 6, 2022
validator/src/main/java/com/google/daq/mqtt/registrar/Registrar.java
Outdated
Show resolved
Hide resolved
validator/src/main/java/com/google/daq/mqtt/registrar/Registrar.java
Outdated
Show resolved
Hide resolved
validator/src/main/java/com/google/daq/mqtt/registrar/LocalDevice.java
Outdated
Show resolved
Hide resolved
Lazier exception catching.
johnrandolph
commented
Apr 8, 2022
grafnu
reviewed
Apr 8, 2022
| @@ -180,19 +196,25 @@ | |||
| private final ExceptionMap exceptionMap; | |||
| private final String generation; | |||
| private final List<DeviceCredential> deviceCredentials = new ArrayList<>(); | |||
| private final TreeMap<String, Object> siteMetadata; | |||
There was a problem hiding this comment.
Seems like it would be cleaner overall to keep the class variable as Metadata (rather than TreeMap), and then convert to TreeMap only at the point of use?
There was a problem hiding this comment.
Then we convert it once per metadata loaded?
There was a problem hiding this comment.
True -- although I've never seen performance be an actual issue with any of this stuff :-). I also think it's only likely to be called relatively infrequently per device (once, maybe twice?) Your call, I'm good either way.
johnrandolph
commented
Apr 8, 2022
grafnu
approved these changes
Apr 8, 2022
grafnu
reviewed
Apr 8, 2022
…o site_wide_defaults
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.