Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge UDMIF into faucetsdn UDMI #296

Merged
merged 376 commits into from
Apr 21, 2022

Conversation

slevertbiot
Copy link
Contributor

This is an initial merge of the UDMIF projects which includes an Angular front end and a GraphQL API service. It also includes a preliminary IaC implementation. All of the work is in progress.

slevertbiot and others added 30 commits March 9, 2022 13:26
updated duplicate  gcp_project to gcp_region
Created build.yml
Added build stage for terraform
updated gcp build
Adding sub total and sorting capabilities
@slevertbiot slevertbiot changed the title Merge request faucetsdn Merge UDMIF into faucetsdn UDMI Apr 14, 2022
Copy link
Collaborator

@grafnu grafnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's one stray .zip file cloud/gcp/function.zip? Or, if it's intended, what is that?

cloud/gcp/index.js is empty -- seems like it only half got moved to cloud/gcp/src/ --?

@slevertbiot
Copy link
Contributor Author

I spoke to the IaC team. They're reviewing their work and should get to updating this next week.

@slevertbiot slevertbiot requested a review from grafnu April 21, 2022 15:26
@grafnu
Copy link
Collaborator

grafnu commented Apr 21, 2022

There's still a cloud/gcp/index.js and cloud/gcp/src/index.js file... are they both right? Also cloud/gcp/package.json is an exact copy of cloud/gcp/src/package.json... ?

Copy link
Collaborator

@grafnu grafnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The index.js and package.json files under cloud/gcp/src and cloud/gcp seem redundant... are both sets supposed to be there?

@slevertbiot
Copy link
Contributor Author

For now, I'm acting as the middle man of this PR. I've let the team know about your latest comments.

@github-biot
Copy link

I think there's one stray .zip file cloud/gcp/function.zip? Or, if it's intended, what is that?

cloud/gcp/index.js is empty -- seems like it only half got moved to cloud/gcp/src/ --?

Those were put there temporary to be able to deploy the cloud function. This will be dynamic in the next PR. We will delete that src folder.

@slevertbiot slevertbiot requested a review from grafnu April 21, 2022 17:11
@grafnu grafnu merged commit 0632590 into faucetsdn:master Apr 21, 2022
@slevertbiot slevertbiot deleted the merge-request-faucetsdn branch August 4, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants