Refactoring of sequence testing code #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * @param args What to do! | ||
| * @param args This is the way |
There was a problem hiding this comment.
What? I wasn't planning on anybody actually reading my comments... that's not fair! (But updated to something more sensical)
| info("Updated state has last_config " + getTimestamp( | ||
| ((State) converted).system.last_config)); | ||
| } else { | ||
| warning("Unknown update type " + converted.getClass().getSimpleName()); |
There was a problem hiding this comment.
Is this severe enough?
| warning("Not resetting config b/c trace is enabled."); | ||
| recordMessages = false; | ||
| if (debugLogLevel()) { | ||
| warning("Not resetting config because debug is enabled."); |
There was a problem hiding this comment.
It isn't clear at first glance why you don't reset the config in this case. Can you add a comment to quickly spell it out?
There was a problem hiding this comment.
Updated the warning message itself to clarify why
johnrandolph
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be functionality neutral -- no new tests or capabilities.