Fix schema for min_loglevel, etc #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y at point level. Add it back to correct places. Remove
grafnu
reviewed
Apr 19, 2022
| @@ -571,9 +571,6 @@ PointPointsetConfig configFromMetadata(PointPointsetMetadata metadata) { | |||
| if (Boolean.TRUE.equals(metadata.writable)) { | |||
| pointConfig.set_value = metadata.baseline_value; | |||
| } | |||
| pointConfig.min_loglevel = metadata.min_loglevel; | |||
There was a problem hiding this comment.
Shouldn't there be new stuff that copies the values into the pointset config? Somewhere in getDevicePointsetConfig()?
There was a problem hiding this comment.
My understanding is that this is an unused artifact of my earlier attempt to provide defaults by setting them directly.
With the schema changes
PointsetMetadata (not PointsetPointMetadata) holds sample_{limit,rate}_sec
SystemConfig and SystemMetadata holds min_loglevel
grafnu
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.