Shell change to be more explicit about shell numeric comparisons #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grafnu
reviewed
Apr 19, 2022
|
-eq -ne are numeric comparison operators. This fixes the OSX wc -w output is " 4 " we saw the other day. |
|
Huh -- tried to read about and the linux man page (for bash) implies that
== is also arithmetic. But, it doesn't matter -- as long as it starts
working properly. Huh, I think the difference (between linux and mac)
actually comes down to how the $( ) parts are handled... i can't quite
figure it out (because I don't have a mac), but some preliminary
experiments did not work as expected on my Linux setup. (Still doesn't
change the fact that using -eq fixes the problem in all cases.)
…On Tue, Apr 19, 2022 at 12:59 PM John R ***@***.***> wrote:
-eq -ne are numeric comparison operators. This fixes the OSX wc -w output
is " 4 " we saw the other day.
—
Reply to this email directly, view it on GitHub
<#301 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIEPD5CXOZC7PX3MX4UBIDVF4GCVANCNFSM5TZ3ZYZA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
multi platform support.
grafnu
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to running these scripts on OSX and wc -w had different stdout