Adding google auth to udmif and enhancing IaC #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get device by
Created gks.tf and vpc.tf
Updated variable
Attached subnet to gke cluster
Update gks.tf
Device summary
Adding points to devices
setup routing for points
Display points
Adding points query
Gcp cleanup
Fixed helm deploy issue
Fixed docker auth issue
modify function.tf
Added docs for build and deploy
Added variables
Added project id in gks
Corrected helm.md
|
What's the status of this PR? Is it waiting for review or... ? |
|
It is waiting for review. Thanks, |
|
It is waiting for review.
Thanks,
Stephane
From: Trevor ***@***.***>
Date: Monday, May 16, 2022 at 8:54 AM
To: faucetsdn/udmi ***@***.***>
Cc: Stephane Levert ***@***.***>, Author ***@***.***>
Subject: Re: [faucetsdn/udmi] Adding google auth to udmif and enhancing IaC (PR #314)
What's the status of this PR? Is it waiting for review or... ?
—
Reply to this email directly, view it on GitHub<https://link.edgepilot.com/s/9496940c/K8DUBa1pHEyJVY0SFWetXw?u=https://github.com/faucetsdn/udmi/pull/314%23issuecomment-1127636595>, or unsubscribe<https://link.edgepilot.com/s/691ce5f0/1qchJI8S0Ea5jkgoe7KG8A?u=https://github.com/notifications/unsubscribe-auth/AMIAKT3KX7AV7FGZ5MYHHVTVKJAP3ANCNFSM5UQHARRA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
Links contained in this email have been replaced. If you click on a link in the email above, the link will be analyzed for known threats. If a known threat is found, you will not be able to proceed to the destination. If suspicious content is detected, you will see a warning.
|
|
Ok -- approved and merged!
…On Tue, Oct 11, 2022 at 1:41 AM slevertbiot ***@***.***> wrote:
It is waiting for review.
Thanks,
Stephane
From: Trevor ***@***.***>
Date: Monday, May 16, 2022 at 8:54 AM
To: faucetsdn/udmi ***@***.***>
Cc: Stephane Levert ***@***.***>, Author ***@***.***>
Subject: Re: [faucetsdn/udmi] Adding google auth to udmif and enhancing
IaC (PR #314)
What's the status of this PR? Is it waiting for review or... ?
—
Reply to this email directly, view it on GitHub<
https://link.edgepilot.com/s/9496940c/K8DUBa1pHEyJVY0SFWetXw?u=https://github.com/faucetsdn/udmi/pull/314%23issuecomment-1127636595>,
or unsubscribe<
https://link.edgepilot.com/s/691ce5f0/1qchJI8S0Ea5jkgoe7KG8A?u=https://github.com/notifications/unsubscribe-auth/AMIAKT3KX7AV7FGZ5MYHHVTVKJAP3ANCNFSM5UQHARRA
>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
Links contained in this email have been replaced. If you click on a link
in the email above, the link will be analyzed for known threats. If a known
threat is found, you will not be able to proceed to the destination. If
suspicious content is detected, you will see a warning.
—
Reply to this email directly, view it on GitHub
<#314 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIEPDYT3QVPBPYAI5CFWBLWCURZ7ANCNFSM5UQHARRA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.