Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change examples according to latest schema version #323

Merged
merged 6 commits into from
May 24, 2022

Conversation

noursaidi
Copy link
Collaborator

  • Adds tests to cover validator message upgrader (new version but old schema and vice versa)
  • Upgrade existing examples to match latest schema (string version, hardware/software instead of make_model/firmware

@noursaidi noursaidi requested a review from grafnu May 17, 2022 08:56
Copy link
Collaborator

@grafnu grafnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember that we don't need to change all the files (or likely shouldn't change them all) since if we want to test backwards compatibility we'll need those files around. Not really a concern with this PR, just FYI in case you were on the warpath to change all the things.

@noursaidi noursaidi merged commit 75214f8 into faucetsdn:master May 24, 2022
@noursaidi noursaidi deleted the examples branch September 20, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants