add pubber missingPoint and noConfigAck options #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grafnu
reviewed
Jun 21, 2022
| @@ -286,7 +286,11 @@ private String getMessageTopic(String deviceId, String topic) { | |||
| } | |||
|
|
|||
| private void subscribeToUpdates(MqttClient client, String deviceId) { | |||
| subscribeTopic(client, String.format(CONFIG_UPDATE_TOPIC_FMT, deviceId), QOS_AT_LEAST_ONCE); | |||
| Integer configQos = QOS_AT_LEAST_ONCE; // Defaults to QoS 1 | |||
There was a problem hiding this comment.
can be "int" rather than "Integer"? Is the value ever null?
There was a problem hiding this comment.
Changed to int. QoS is either 0,1, or 2. The paho mqttClient.subscribe method expects an int when QoS is provided so don't think it's ever/can be null.
| @@ -286,7 +286,11 @@ private String getMessageTopic(String deviceId, String topic) { | |||
| } | |||
|
|
|||
| private void subscribeToUpdates(MqttClient client, String deviceId) { | |||
| subscribeTopic(client, String.format(CONFIG_UPDATE_TOPIC_FMT, deviceId), QOS_AT_LEAST_ONCE); | |||
| Integer configQos = QOS_AT_LEAST_ONCE; // Defaults to QoS 1 | |||
| if (configuration.options.noConfigAck != null && configuration.options.noConfigAck) { | |||
There was a problem hiding this comment.
I'd typically write this as:
boolean noConfigAck = configuration.options.noConfigAck != null && configuration.options.noConfigAck;
int configQos = noConfigAck ? QOS_AT_MOST_ONCE : QOS_AT_LEAST_ONCE;
It's a bit more concise (less fluff) and is somewhat self-documenting, and prevents overwriting a defined value.
There was a problem hiding this comment.
Thanks! Does look better. Changed, but wrapped the long line
grafnu
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missingPoint option to remove a point from pubber, and a noConfigAck option which sets config subscription QoS to 0 (therefore no puback)