Redirect #376
Merged
Redirect #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnrandolph
approved these changes
Jun 27, 2022
|
|
||
| private void disconnectMqtt() { | ||
| Preconditions.checkState(mqttPublisher != null, "mqttPublisher not defined"); | ||
| mqttPublisher.close(); |
There was a problem hiding this comment.
Does this handle any kind of completion of sending messages (whether that's desired or not), or just drop the connection?
|
I'm not sure... I would assume it waits for everything in the outgoing
queue to be sent. There's also things we'll want to do with sending a UDMI
status update that says "we're about to redirect" and we'll need to make
sure that gets through, etc... There's a lot of error handling in general
I didn't deal with here -- so I'll need to go through and clean that stuff
up later for sure!
…On Mon, Jun 27, 2022 at 2:21 PM John R ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In pubber/src/main/java/daq/pubber/Pubber.java
<#376 (comment)>:
> @@ -547,6 +549,16 @@ private void initialize() {
throw new RuntimeException("While creating out dir " + outDir.getPath(), e);
}
+ initializeMqtt();
+ }
+
+ private void disconnectMqtt() {
+ Preconditions.checkState(mqttPublisher != null, "mqttPublisher not defined");
+ mqttPublisher.close();
Does this handle any kind of completion of sending messages (whether
that's desired or not), or just drop the connection?
—
Reply to this email directly, view it on GitHub
<#376 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIEPD36XWKAAMRLF4W2PALVRHWJJANCNFSM5Z7HDBBQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial version of Pubber that accepts a registryRedirect option