Add message trace/playback capability (for testing) #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should the message attributes be stored and read back too? I don't think they're used at the moment, but the use case in my mind would be be the timestamp validation using the publishTimestamp from attribute? |
|
Likely yes, but I was trying to keep things focused rather than do
everything... Right now, the attributes are implicitly defined by the
message filename (which includes the device ID and subfolder), and the time
comes from the message itself. The other parameters (projectId,
deviceNumId, etc...) -- are largely irrelevant.
…On Tue, Jul 19, 2022 at 9:16 AM Noureddine ***@***.***> wrote:
Should the message attributes be stored and read back too? I don't think
they're used at the moment, but the use case in my mind would be be the
timestamp validation using the publishTimestamp from attribute?
—
Reply to this email directly, view it on GitHub
<#392 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIEPD357KZM75UYWEDL3K3VU3IEHANCNFSM54AM5B5Q>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
johnrandolph
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files in traces/ are captured messages that are used for test playback (so don't need to really be reviewed). Everything else is to support trace/playback/test capabilities.