Fix output generation for device validation reports #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnrandolph
reviewed
Aug 1, 2022
| return errors.size() == 1 ? makeEntry(errors.get(0)) : makeCompoundEntry(errors); | ||
| } | ||
|
|
||
| private Entry makeCompoundEntry(List<Exception> erx) { |
There was a problem hiding this comment.
Could we have docstrings that give example input/output here? github doesn't lend itself to jumping around very quickly to piece it together.
There was a problem hiding this comment.
Done -- added javadoc to ~4 or so of the methods relating to this.
johnrandolph
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things in validator/trace/simple/ can be ignored (trace input files)
Things in validator/trace/simple.out/ are examples of what the output produced is, so should be checked for completeness.
Other code bits deserve code-review as per normal.