Creating formal schema definitions for misc config files #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnrandolph
reviewed
Aug 9, 2022
schema/pubber_configuration.json
Outdated
| "type": "string" | ||
| }, | ||
| "keyBytes": { | ||
| "description": "Should be type byte[], but that can't be represented in json schema" |
There was a problem hiding this comment.
What type is it then?
|
The java code generator creates it as a generic Object, and then explicit
type-casts are used to make it byte[] as needed. I updated the comment to
add that bit of detail.
…On Tue, Aug 9, 2022 at 12:32 PM John R ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In schema/pubber_configuration.json
<#414 (comment)>:
> + "keyFile": {
+ "type": "string",
+ "default": "local/rsa_private.pkcs8"
+ },
+ "algorithm": {
+ "type": "string",
+ "default": "RS256"
+ },
+ "serialNo": {
+ "type": "string"
+ },
+ "macAddr": {
+ "type": "string"
+ },
+ "keyBytes": {
+ "description": "Should be type byte[], but that can't be represented in json schema"
What type is it then?
—
Reply to this email directly, view it on GitHub
<#414 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIEPD7XRZXJQUZ5Y24NJ4TVYKW3DANCNFSM56BZR4SQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
johnrandolph
approved these changes
Aug 10, 2022
| @@ -261,6 +265,13 @@ private static void startFeedListener(String projectId, String siteName, String | |||
| } | |||
| } | |||
|
|
|||
| private static PubberConfiguration sanitizeConfiguration(PubberConfiguration configuration) { | |||
There was a problem hiding this comment.
this is more like build, right?
|
It's actually taking an existing object in cleaning it up (thus sanizing)
-- not just building one from scratch!
…On Wed, Aug 10, 2022 at 7:41 AM John R ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In pubber/src/main/java/daq/pubber/Pubber.java
<#414 (comment)>:
> @@ -261,6 +265,13 @@ private static void startFeedListener(String projectId, String siteName, String
}
}
+ private static PubberConfiguration sanitizeConfiguration(PubberConfiguration configuration) {
this is more like build, right?
—
Reply to this email directly, view it on GitHub
<#414 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIEPD6HSHNZXOCOEVOJEMTVYO5SJANCNFSM56BZR4SQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.