-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct writeback_state sequence test #450
Merged
Merged
Changes from 18 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
17f0676
fix writeback sequence test to work as expected
noursaidi 13dacfd
Update generated.md
noursaidi 1ed02c9
Adding test sequence sample out
grafnu 40fa743
add ci check for validator/sequences
noursaidi 37471cb
change clone_model checkout target
noursaidi 6e76c83
Update sequence-generator to work with property maps (#15)
grafnu be9b7fb
new generated.md (but not comitted validator proofs)
noursaidi 6649742
commit sequencer proofs (expect pass)
noursaidi 6ab4205
Fixing semantic dates for discovery (#16)
grafnu 12a967c
add sequencer output files
noursaidi 05b93a1
sequencer.out
noursaidi b32f1a1
Merge branch 'master' into writeback_test1
noursaidi a990010
restore gcp_device_logs
noursaidi 04357df
comments - clone model and gitattributes
noursaidi 65d9ed5
Merge branch 'master' into writeback_test1
noursaidi dd55bd5
remove irrelevant log files
noursaidi 9de2072
remove extra valid_serial_no from sequencer.out
noursaidi 779f38a
sequencer.out
noursaidi f4e745b
Fix recusrion (#17)
grafnu 99a92e7
test ci - expect failure
noursaidi d072d15
Merge branch 'writeback_test1' of github.com:noursaidi/udmi into writ…
noursaidi 06d1437
flip validation directory and add generated.md
noursaidi 5d1a6b7
generated.md extra line
noursaidi 781955f
add endpoint_config (expect fail)
noursaidi d4718b4
expect pass
noursaidi 1ecc1c2
fix
noursaidi 9dca779
empty
noursaidi 448b5be
add logging to ci
noursaidi 6a81454
remove additional logging
noursaidi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,4 @@ | ||
/gencode/** linguist-generated=true | ||
validator/sequences/**/*.json linguist-generated=true | ||
validator/sequences/**/*.attr linguist-generated=true | ||
validator/sequences/**/*.log linguist-generated=true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
...s/WritebackValidator_writeback_states.xml → ...s/WritebackSequences_writeback_states.xml
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,13 @@ | ||
|
||
## writeback_states | ||
|
||
1. Test failed: Missing 'invalid' target specification | ||
1. Wait for point filter_differential_pressure_sensor to have value_state default (null) | ||
1. Wait for point filter_alarm_pressure_status to have value_state default (null) | ||
1. Wait for point filter_differential_pressure_setpoint to have value_state default (null) | ||
1. Update config: | ||
* Add `pointset.points.filter_alarm_pressure_status.set_value` = `false` | ||
* Set `pointset.points.filter_differential_pressure_setpoint.set_value` = `60` | ||
* Add `pointset.points.filter_differential_pressure_sensor.set_value` = `15` | ||
1. Wait for point filter_differential_pressure_sensor to have value_state invalid | ||
1. Wait for point filter_alarm_pressure_status to have value_state failure | ||
1. Wait for point filter_differential_pressure_setpoint to have value_state applied |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
be warned, what I discovered the other day is that the shell in GitHub Actions doesn't always process failure conditions correctly. Did you check that this actually fails the run when there's a problem? ( You could quickly check by tweaking the validator/sequences/%/sequence.md file)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I've checked and it does fail when there is a difference or missing file.