Add endpoint_config_connection_error test #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grafnu
reviewed
Sep 16, 2022
validator/src/main/java/com/google/daq/mqtt/sequencer/sequences/ConfigSequences.java
Outdated
Show resolved
Hide resolved
validator/src/main/java/com/google/daq/mqtt/sequencer/sequences/ConfigSequences.java
Outdated
Show resolved
Hide resolved
| deviceConfig.blobset.blobs.put("_iot_endpoint_config", cfg); | ||
|
|
||
| updateConfig(); | ||
| untilTrue("pubber has attempted endpoint reconfig", () -> { |
There was a problem hiding this comment.
it's not always pubber -- this might be running against a manufacturer device
validator/src/main/java/com/google/daq/mqtt/sequencer/sequences/ConfigSequences.java
Outdated
Show resolved
Hide resolved
| BlobBlobsetConfig cfg = new BlobBlobsetConfig(); | ||
| cfg.phase = BlobPhase.FINAL; | ||
| // { protocol=mqtt, client_id=test_project/device; hostname=localhost } | ||
| cfg.base64 = "ewogICJwcm90b2NvbCI6ICJtcXR0IiwKICAiY2xpZW50X2lkIjogInRlc3RfcHJvamVjdC9kZXZp" |
There was a problem hiding this comment.
extract to named constant for base64 for readability?
validator/src/main/java/com/google/daq/mqtt/sequencer/sequences/ConfigSequences.java
Outdated
Show resolved
Hide resolved
|
Yes -- this is a very very common case for many tests, which is why I
pulled the functionality into untilTrue -- it makes the code a lot cleaner
overall because all the try/catch blocks are essentially noise to the
underlying test-specific logic. Also, this way it's easier to have the
configured loglevel handle the exception appropriately -- e.g. mostly
silently ignore except when in verbose mode, and then show what's going
on...
…On Fri, Sep 16, 2022 at 10:33 AM John R ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
validator/src/main/java/com/google/daq/mqtt/sequencer/sequences/ConfigSequences.java
<#455 (comment)>:
> + @description("Push endpoint config message to device that results in a connection error.")
+ public void endpoint_config_connection_error() {
+ // blob _iot_endpoint_config = ...
+ BlobBlobsetConfig cfg = new BlobBlobsetConfig();
+ cfg.phase = BlobPhase.FINAL;
+ // { protocol=mqtt, client_id=test_project/device; hostname=localhost }
+ cfg.base64 = "ewogICJwcm90b2NvbCI6ICJtcXR0IiwKICAiY2xpZW50X2lkIjogInRlc3RfcHJvamVjdC9kZXZp"
+ + "Y2UiLAogICJob3N0bmFtZSI6ICJsb2NhbGhvc3QiCn0K";
+ cfg.content_type = "application/json";
+ deviceConfig.blobset = new BlobsetConfig();
+ deviceConfig.blobset.blobs = new HashMap<String, BlobBlobsetConfig>();
+ deviceConfig.blobset.blobs.put("_iot_endpoint_config", cfg);
+
+ updateConfig();
+ untilTrue("pubber has attempted endpoint reconfig", () -> {
+ try {
Even though we will almost certainly NPE > 1 ?
—
Reply to this email directly, view it on GitHub
<#455 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIEPD4JZ53SOATHWBIY553V6SVMZANCNFSM6AAAAAAQOOAOCY>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
grafnu
reviewed
Sep 16, 2022
validator/src/main/java/com/google/daq/mqtt/sequencer/sequences/BlobsetSequences.java
Outdated
Show resolved
Hide resolved
| import org.junit.Test; | ||
| import udmi.schema.BlobBlobsetConfig; |
There was a problem hiding this comment.
extra stuff not necessary anymore?
There was a problem hiding this comment.
Which thing is extra?
There was a problem hiding this comment.
All the changes in the file... aren't they leftover from when you had the test itself in there?
There was a problem hiding this comment.
Oh haha. Yes of course. One moment
validator/src/main/java/com/google/daq/mqtt/sequencer/sequences/BlobsetSequences.java
Outdated
Show resolved
Hide resolved
grafnu
reviewed
Sep 16, 2022
| deviceConfig.blobset.blobs.put(String.valueOf(SystemBlobsets.IOT_ENDPOINT_CONFIG), config); | ||
|
|
||
| untilTrue("device tried endpoint config which resulted in connection error", () -> { | ||
| Entry stateStatus = deviceState.blobset.blobs.get(SystemBlobsets.IOT_ENDPOINT_CONFIG).status; |
There was a problem hiding this comment.
If this works it's fine, but I'd be wondering why .value() isn't necessary here when it is elsewhere... basically if this doesn't work for some reason just something to consider!
There was a problem hiding this comment.
idk, I let intellij ask for the other value()
validator/src/main/java/com/google/daq/mqtt/sequencer/sequences/BlobsetSequences.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.