add "commit" to endpoint reconfiguration #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So I would say no -- it ultimately adds a lot of extra stuff with no value.
I'd just start with the state (phase == final), and then enough afterwards
to indicate that it's sticky (e.g. connects to the new endpoint not the old
one). I would expand the "REBOOT DEVICE" box to indicate that it's a
sequence from the new config (not sure if we want to add in an arrow for
that), and then a corresponding box like before that says the state last
update should match the last config (from reboot). Not 100% sure, but at
least that's what I'd try as the next iteration.
…On Wed, Sep 21, 2022 at 1:13 PM Noureddine ***@***.***> wrote:
Preview link -
https://noursaidi.github.io/udmi/docs/specs/sequences/endpoint_reconfiguration.html
Essentially normal redirect with a box that says reboot .. One question
is, given the first sequence diagram checks all "phases" does the second
diagram need to do it too?
------------------------------
You can view, comment on, or merge this pull request online at:
#463
Commit Summary
- 8a616b5
<8a616b5>
initial commit diagram
File Changes
(1 file <https://github.com/faucetsdn/udmi/pull/463/files>)
- *M* docs/specs/sequences/endpoint_reconfiguration.md
<https://github.com/faucetsdn/udmi/pull/463/files#diff-f590158765b1060135edfe5a5f32922f4db99fe907f15f7e105021f8aed25741>
(23)
Patch Links:
- https://github.com/faucetsdn/udmi/pull/463.patch
- https://github.com/faucetsdn/udmi/pull/463.diff
—
Reply to this email directly, view it on GitHub
<#463>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIEPD4VVSPDCQ7HVXHR7ATV7NT7VANCNFSM6AAAAAAQSNDRXU>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
grafnu
approved these changes
Sep 22, 2022
| participant E as Original Endpoint | ||
| participant E' as New Endpoint | ||
| D->>E':STATE MESSAGE<br/>blobset.blobs._iot_endpoint_config.phase = "final" | ||
| note over D,E': Reboot sequence from new endpoint |
There was a problem hiding this comment.
nit: New Endpoint (capital) since it's a specific thing
| note over D,E': Reboot sequence from new endpoint | ||
| D->>E':STATE MESSAGE<br/>blobset.blobs._iot_endpoint_config.phase = "final" | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Maybe add a simple note after that just says "This just means the new endpoint connection is remembered after a system restart" I dunno -- it's one of those "it's so simple I'm not sure people will see it!" situations...
| participant E as Original Endpoint | ||
| participant E' as New Endpoint | ||
| D->>E':STATE MESSAGE<br/>blobset.blobs._iot_endpoint_config.phase = "final" | ||
| note over D,E': Reboot sequence from new endpoint |
There was a problem hiding this comment.
nit: I'm calling it "restart" not "reboot" not sure what the exact difference would be -- but I was going with the terminology my laptop uses :-).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview link - https://noursaidi.github.io/udmi/docs/specs/sequences/endpoint_reconfiguration.html
Essentially normal redirect with a box that says reboot .. One question is, given the first sequence diagram checks all "phases" does the second diagram need to do it too?