Merge different configuration objects, and create the basic foundation for profiles-in-validator #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnrandolph
approved these changes
Oct 12, 2022
| @@ -20,9 +20,6 @@ if [ ! -f $site_path/cloud_iot_config.json ]; then | |||
| false | |||
| fi | |||
|
|
|||
| echo Building validator... | |||
There was a problem hiding this comment.
What is this change?
There was a problem hiding this comment.
This was redundant with a build operation lower down in the stack, so just removing to reduce overall code.
| @@ -76,12 +77,33 @@ public static void toJsonFile(File file, Object target) { | |||
| } | |||
| } | |||
|
|
|||
| public static <T> T deepCopy(T endpoint1, Class<T> valueType) { | |||
| @SuppressWarnings("unchecked") | |||
There was a problem hiding this comment.
Is there anything interesting and useful we can comment here about why we need this? Is it the return or the cast? Same question for the other functions.
There was a problem hiding this comment.
Moved the @SuppressWarnings to specific field declarations where the type-cast is more clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is large because it's a refactoring that touches lots of little things (class name changes) in lots of files. The actual functionality change it very small, and is centered around a consolidated use of a "configuration object" that's used in the validator main startup. Everything else is essentially a rename/refactor.
The only real new "logic" here this one small function, that allows for reading in a file to provide basic values rather than relying on pure command-line arguments.