Add additional gcloud miscellaneous tooling #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misc/gcloud_iot_config/deploy
Outdated
| FUNCTION_NAME=gcloud_iot_config | ||
| ENTRY_POINT=storeConfig | ||
| TOPIC=config_updates | ||
| BUCKET=$PROJECT_ID-iot-configs |
There was a problem hiding this comment.
${PROJECT_ID}-iot-configs here and anywhere else that a literal and a variable are adjacent?
|
|
||
| **NOTE** | ||
| - Requires **Cloud Logging** on devices or registry be set to `INFO` or more. | ||
| - IoT Core has a default log entries limit of 2000 per second. If a regsitry has `DEBUG` level logging, this may very quickly be exceeding, and will result in missing connection or disconnection log events |
| except futures.TimeoutError: | ||
| continue | ||
| except (futures.CancelledError, KeyboardInterrupt): | ||
| future.cancel() |
There was a problem hiding this comment.
do you want to fall through here?
misc/gcloud_store_message/deploy
Outdated
| #!/bin/bash | ||
|
|
||
| if (( $# < 4 )); then | ||
| echo $0 PROJECT_ID DATASET_ID LOCATION TRIGGER_TOPIC [--drop] |
There was a problem hiding this comment.
Does this script support --drop ? maybe remove it?
grafnu
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included more of my scripts including
Also moved deploy scripts into their own directory
All have been tested/deployed in my projects, however here I have modified slightly to fix unnecesary cloud function logs and service account issues, but have not (at least at time of writing) tested the modified versions work. Also atm they also all use the app engine default credentials which might not have sufficient permissions in some projects, although creating a service account per cloud function is very quick to do.