Split writeback tests #498
Conversation
etc/sequencer_solo.out
Outdated
| @@ -0,0 +1,4 @@ | |||
| TESTING writeback_success_state with pubber opts: noWriteback | |||
There was a problem hiding this comment.
I would turn this into an in/out file, that is also the input to the testing, e.g.:
TEST writeback_success_state noWriteback RESULT fail writeback_success_state timeout waiting for point filter_differential_pressure_setpoint to have value_state applied
as one line could automatically be parsed to extract the first part so it's not replicated in the test script
There was a problem hiding this comment.
Changed as requested
bin/test_sequencer_solo
Outdated
| SEQUENCER_OUT=/tmp/sequencer.log | ||
| TEST_LIST=/tmp/solo_sequencer_tests.txt | ||
|
|
||
| cat > $TEST_LIST <<EOF |
There was a problem hiding this comment.
as per other comment, I think this should be parsed out of the in/out file, not as a separate list maintained here
There was a problem hiding this comment.
Changed to read the tests from the "golden file"
bin/test_sequencer_solo
Outdated
| @@ -0,0 +1,54 @@ | |||
| #!/bin/bash -e | |||
There was a problem hiding this comment.
I'd prefer a name like "test_itemized" or something to 1) avoid the test_sequencer prefix, and then 2) something a bit more descriptive than _solo.
There was a problem hiding this comment.
renamed to test_itemized
bin/test_itemized
Outdated
| PROJECT_ID=$1 | ||
| shift 1 | ||
|
|
||
| REGEX="^TEST ([a-z_]+)([A-Za-z ]+)?(RESULT .*)?$" |
There was a problem hiding this comment.
What's this used for? I don't see it anywhere in the file... ??
Split writeback test into:
writeback_success_applycan the device update the value of a point through writebackwriteback_success_statecan the device update the value of a point through writeback and sets thevalue_statetoappliedwriteback_invalid_statedoes the device reportinvalidin a pointsvalue_statewhen the value is known to be invalidwriteback_failure_statedoes the device reportfailurein a pointsvalue_statewhen the value is known to be invalidAlso add a utility
bin/test_sequencer_soloto test a single sequence test against a pubber instance with given options (to test failures or edge cases .. similar to the one DAQ had). For some reason this works locally, but in CI it goes through the first line (irrespective of how many lines the file has) .. haven't figured that bit out