Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes to pubber and sequencer #519

Merged
merged 21 commits into from
Dec 5, 2022
Merged

Various fixes to pubber and sequencer #519

merged 21 commits into from
Dec 5, 2022

Conversation

johnrandolph
Copy link
Collaborator

No description provided.

@johnrandolph johnrandolph changed the title x Various fixes to pubber and sequencer Nov 28, 2022
grafnu
grafnu approved these changes Dec 2, 2022
View reviewed changes
Copy link
Collaborator

@grafnu grafnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing missing would be unit tests for some of the classes (SemanticValue or ConfigDiffEngine) -- if we want to increase test coverage for these then I'd recommend doing it now as part of this PR.

@johnrandolph johnrandolph marked this pull request as ready for review December 5, 2022 16:39
@johnrandolph johnrandolph merged commit 1b5a350 into faucetsdn:master Dec 5, 2022
@johnrandolph johnrandolph deleted the reset_fixes branch December 7, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grafnu grafnu grafnu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnrandolph @grafnu