-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature-neutral refactoring of testing framework #528
Conversation
bin/test_sequencer
Outdated
|
||
echo "Workflow run number $GITHUB_RUN_NUMBER" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be [[ ! -z $VAR...]] && echo "...." here and elsewhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here yes, other places I think it's useful to have the output in either case
@@ -444,12 +449,20 @@ private void validateMessage(JsonSchema schema, Object message) { | |||
} | |||
|
|||
private void sanitizeMessage(String schemaName, Map<String, Object> message) { | |||
message.remove(SequenceBase.CONFIG_NONCE_KEY); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this sanitizeBlock(message)
No description provided.