Add @Feature annotation with categories #566
Conversation
|
|
||
| /** | ||
| * Enum of allowed stages. | ||
| */ |
There was a problem hiding this comment.
Is there a doc that pinpoints what each of these stages means to the UDMI project? For example ALPHA vs PREVIEW
There was a problem hiding this comment.
Also occurs to me, should "REQUIRED" be renamed "RELEASE"?
There was a problem hiding this comment.
I'd like to scope this PR at the mechanism for specifying the properties, but not the properties themselves (leave changing that to a separate PR). Once this PR is in place, it's easy to add/change the values themselves, and/or the properties associated with any given feature.
There was a problem hiding this comment.
If you change the enum to just one placeholder value I'm good with that. Then we can go back and edit the real values in place.
There was a problem hiding this comment.
How about two -- I'd like to keep default and non-default since the code/output is different in those two cases! Updated, PTAL.
There was a problem hiding this comment.
Ok...as long as we can change REQUIRED to a different label if needed lgtm
validator/src/main/java/com/google/daq/mqtt/sequencer/sequences/BlobsetSequences.java
Outdated
Show resolved
Hide resolved
|
Eventually yes, but I'd like to keep that as a separate activity. After
this PR, I want to have some generated NAMED_CONSTANTS for the categories
to prevent string typos, etc... Similar to the error categories! All just
staging steps to the eventual goal...
…On Thu, Jan 26, 2023 at 1:35 PM John R ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
validator/src/main/java/com/google/daq/mqtt/sequencer/sequences/BlobsetSequences.java
<#566 (comment)>:
> @@ -198,7 +198,7 @@ public void endpoint_connection_success_alternate() {
@test
@description("Restart and connect to same endpoint and expect it returns.")
- @FeatureStage(PREVIEW)
+ @feature(stage = PREVIEW)
I meant should we fill in category values that Nour is generating. But we
can revisit this when we settle the enums, too.
—
Reply to this email directly, view it on GitHub
<#566 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIEPD5T65JYGOLVYTJQBWTWULU3RANCNFSM6AAAAAAUGKQZQQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
|
||
| /** | ||
| * Enum of allowed stages. | ||
| */ |
There was a problem hiding this comment.
Ok...as long as we can change REQUIRED to a different label if needed lgtm
No description provided.