-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix schema validation entry on legacy site #792
Conversation
System.err.println( | ||
String.format( | ||
"Device has missing points: %s", | ||
Joiner.on(", ").join(missingPoints) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: there's com.google.udmi.util.GeneralUtils.CSV_JOINER for this... very minor savings in characters :-)
@@ -201,12 +201,24 @@ public void validateMessageType(Object message, Date timestamp, Map<String, Stri | |||
} else if (!missingPoints.isEmpty()) { | |||
addError(pointValidationError("missing points", missingPoints), attributes, | |||
Category.VALIDATION_DEVICE_CONTENT); | |||
System.err.println( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
System.err.printf() is a thing!
} | ||
|
||
extraPoints = metadataDiff.extraPoints; | ||
if (extraPoints != null && !extraPoints.isEmpty()) { | ||
addError(pointValidationError("extra points", extraPoints), attributes, | ||
Category.VALIDATION_DEVICE_CONTENT); | ||
System.err.println( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto x2
No description provided.