Use http2 for streaming when is nodeJS #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryancharris
reviewed
Oct 28, 2020
ryancharris
approved these changes
Nov 2, 2020
|
@BrunoQuaresma Heads up that this is failing CI. |
erickpintor
reviewed
Nov 2, 2020
|
|
||
| var request = client.request( | ||
| { | ||
| ...headers, |
There was a problem hiding this comment.
Is this ES5 compatible?
There was a problem hiding this comment.
Good catch, I think this is not.
There was a problem hiding this comment.
atm indeed "Uncaught ReferenceError: http2 is not defined"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.