Fix backward compatibility bug introduced in 4.5.3 that causes query to return a differnt type #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to return a differnt type
faunaee
previously approved these changes
Mar 30, 2022
henryfauna
approved these changes
Mar 30, 2022
|
Thanks for the revert. This caused some pain and some hours. |
Sorry for the bad release @grempe! Happy to hear you are unstuck. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
4.5.3 introduced a bug that broke backward compatibility - it started returning a union of two types on
queryinstead of just a single type.This commit fixes that bug by reverting query to the old interface. It does so by:
Customers will instead need to use queryWithMetrics to get these metrics.
Testing
Pending circleci