Set max session idle time #642
Conversation
|
Noting that @henryfauna mentioned @faunaee called out we should determine how this impacts streaming, as it could change our implementation. (good call out @faunaee !) |
|
@henryfauna please prepare this as a new driver version following the guide here: https://faunadb.atlassian.net/wiki/spaces/DX/pages/3002335237/Drivers#JS-driver-release |
test/stream.test.js
Outdated
|
|
||
| const { ts: newTimestamp } = await client.query(q.Update(doc.ref, {})) | ||
| expect(newTimestamp).toBeGreaterThan(oldTimestamp) | ||
| await util.delay(idleTime + 1) |
There was a problem hiding this comment.
Wouldn't it be worth checking that the stream is still open beyond the maximum value of http2SessionIdleTime? As written, this test doesn't really demonstrate that a stream is held open indefinitely, just that it is held open for 2002 ms (which is well within 5000ms).
There was a problem hiding this comment.
The test should be updated now
src/Client.js
Outdated
| for (const rawValue of values) { | ||
| const parsedValue = parseInt(rawValue, 10) | ||
| const isNegative = parsedValue < 0 | ||
| const isInfinity = rawValue === 'Infinity' |
There was a problem hiding this comment.
Wouldn't it be easier to do this check first?
The overall check could be simpler, too:
// Handle Infinity, and NaN (for any other string)
const parsedValue = rawValue === 'Infinity'
? Number.MAX_SAFE_INTEGER
: parseInt(rawValue, 10) || defaultIdleTime
// Handle upper bound
if (parsedValue > maxIdleTime) parsedValue = maxIdleTime
// Handle lower bound
if (parsedValue < 0) parsedValue = defaultIdleTime
return parsedValue
Notes
Jira Ticket
Previously "Infinity" was a possible value for
http2SessionIdleTime. This change enforces a maximum value of5000milliseconds.How to test
yarn test