Skip to content

Commit

Permalink
Remove a broken link in Readme.md (#332)
Browse files Browse the repository at this point in the history
* Remove a broken link in Readme.md

The link for open file limit was dead. The solution is elaborated in a short, compact way.

* Reformat code

* Fix formatting

* Move noqa note to propagate

* Fix formatting in streams.py

Co-authored-by: William Barnhart <williambbarnhart@gmail.com>
  • Loading branch information
sefadegirmenci and wbarnha committed Aug 3, 2022
1 parent 0bb2685 commit 9eb770a
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 4 deletions.
11 changes: 9 additions & 2 deletions README.md
Expand Up @@ -407,8 +407,15 @@ introduced in Python 3.6 (`async`, `await`, variable type annotations).

### I get a maximum number of open files exceeded error by RocksDB when running a Faust app locally. How can I fix this

You may need to increase the limit for the maximum number of open files. The
following post explains how to do so on OS X: https://blog.dekstroza.io/ulimit-shenanigans-on-osx-el-capitan/
You may need to increase the limit for the maximum number of open files.
On macOS and Linux you can use:

```ulimit -n max_open_files``` to increase the open files limit to max_open_files.

On docker, you can use the --ulimit flag:

```docker run --ulimit nofile=50000:100000 <image-tag>```
where 50000 is the soft limit, and 100000 is the hard limit [See the difference](https://unix.stackexchange.com/a/29579).

### What kafka versions faust supports

Expand Down
4 changes: 2 additions & 2 deletions faust/streams.py
Expand Up @@ -394,8 +394,8 @@ async def add_to_buffer(value: T) -> T:
async def take_with_timestamp(
self, max_: int, within: Seconds, timestamp_field_name: str
) -> AsyncIterable[Sequence[T_co]]:
"""Buffer n values at a time and yield a list of buffered values with the timestamp
when the message was added to kafka.
"""Buffer n values at a time and yield a list of buffered values with the
timestamp when the message was added to kafka.
Arguments:
max_: Max number of messages to receive. When more than this
Expand Down

0 comments on commit 9eb770a

Please sign in to comment.