Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding new feature to retry on Aerospike runtime exceptions Issue#202 #203

Merged
merged 6 commits into from Oct 21, 2021

Conversation

patkivikram
Copy link
Collaborator

Note: Before submitting this pull request, please review our contributing
guidelines
.

Description

Fixes #202

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2021

Codecov Report

Merging #203 (60bea84) into master (808312b) will decrease coverage by 0.05%.
The diff coverage is 54.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #203      +/-   ##
==========================================
- Coverage   94.51%   94.46%   -0.06%     
==========================================
  Files         100      100              
  Lines       10631    10643      +12     
  Branches     1202     1199       -3     
==========================================
+ Hits        10048    10054       +6     
- Misses        514      524      +10     
+ Partials       69       65       -4     
Impacted Files Coverage Δ
faust/stores/aerospike.py 76.82% <54.28%> (-2.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 808312b...60bea84. Read the comment docs.

@taybin
Copy link
Contributor

taybin commented Oct 21, 2021

Did you consider using a library like tenacity? I've used that in my faust client and it works well. I know it expands the requirements, but if we want to start having retry code elsewhere, it might be better to use something like that than re-implementing it.

@patkivikram
Copy link
Collaborator Author

Did you consider using a library like tenacity? I've used that in my faust client and it works well. I know it expands the requirements, but if we want to start having retry code elsewhere, it might be better to use something like that than re-implementing it.

No I havent looked into it yet. Let me take a look and post a PR with an update

@patkivikram patkivikram merged commit 868d7a4 into master Oct 21, 2021
@wbarnha wbarnha deleted the aerospike_retries branch July 3, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aerospike RuntimeExceptions must be retried
3 participants