Python 3.10 #205
Python 3.10 #205
Conversation
Codecov Report
@@ Coverage Diff @@
## master #205 +/- ##
==========================================
- Coverage 94.71% 94.71% -0.01%
==========================================
Files 100 100
Lines 10842 10840 -2
Branches 1481 1515 +34
==========================================
- Hits 10269 10267 -2
Misses 500 500
Partials 73 73
Continue to review full report at Codecov.
|
|
Converted to draft PR until we can point to a real mode-streaming release. |
|
Maybe edit the PR to merge to your color-less branch, that way this PR wouldn't show those changes too. |
|
any chance to merge this PR soon? |
|
I see mode-streaming lists @taybin as maintainer, with a release from last week, and I'm very excited. Where must I send my cryptokitties to shepherd this along? Or I can do your laundry? Mow your lawn? Hell, I'll floss your teeth for you, or floss my teeth in your stead, with an official note to pass to your dentist! |
|
@taybin , is there anything stopping this being pointed to the new streaming? |
|
@taybin Would love for this PR to get merged ASAP as there doesn't seem to be any blockers. Happy to help if required. |
|
I'm going to get this ready for testing today. |
|
whose back do i gotta scratch to apply a diff? @patkivikram? diff --git a/faust/streams.py b/faust/streams.py
index 111be051..c87db350 100644
--- a/faust/streams.py
+++ b/faust/streams.py
@@ -414,8 +414,8 @@ class Stream(StreamT[T_co], Service):
buffer_add = buffer.append
event_add = events.append
buffer_size = buffer.__len__
- buffer_full = asyncio.Event(loop=self.loop)
- buffer_consumed = asyncio.Event(loop=self.loop)
+ buffer_full = asyncio.Event()
+ buffer_consumed = asyncio.Event()
timeout = want_seconds(within) if within else None
stream_enable_acks: bool = self.enable_acks |
|
Okay, the tests are passing. I suppose now we just need a PR approval and merge and then a beta release for trying it out. |
|
@patkivikram What do you think? Can this get merged? |
|
@patkivikram @austinnichols101 any update on this? |
|
Am I missing something here? It looks as though all the work has been done, there is reasonable interest from the community but maintainers are just ignoring it. It is not that the maintainers are MIA, they are just (actively?) ignoring this. No mention of "you forgot ABC" or "we need better testing" or even "we don't want this on grounds of principle because XYZ". Is there something political I am missing here? Is there something dubious with 3.10 that I have failed to find? |
|
@AntonOfTheWoods Cant agree more... Would definitely like this to get merged. |
|
Thank you @austinnichols101 and @taybin !!! |
|
When we are releasing this? |
* Remove deprecated loop argument for python-3.10 * reformat file for black * remove unused variable, fix typo * at least point to the faust-streaming/mode repo * fix noack_take() for python-3.10 * use black to add commas * set mode-streaming to 0.2.0 or higher * remove loop argument from Event (thank you @theY4Kman)
This builds off of #204 to remove the deprecated loop argument that was finally removed in python-3.10.
It uses an unreleased version of mode so probably blocked on releasing mode-0.2.0, but the tests pass.