Discard message after rebalance #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 11, 2021 13:45
…o discard_message_after_rebalance
patkivikram
reviewed
Nov 19, 2021
| @@ -158,6 +160,9 @@ cdef class StreamIterator: | |||
| offset = message.offset | |||
| consumer = self.consumer | |||
|
|
|||
| if message.generation_id != self.app.consumer_generation_id: | |||
| return None, self._skipped_value, stream_state | |||
| @@ -974,6 +974,9 @@ async def _py_aiter(self) -> AsyncIterator[T_co]: | |||
| tp = message.tp | |||
| offset = message.offset | |||
|
|
|||
| if message.generation_id != self.app.consumer_generation_id: | |||
| value = skipped_value | |||
There was a problem hiding this comment.
Can we log this? It will be easier to debug if this were to happen
Codecov Report
@@ Coverage Diff @@
## master #223 +/- ##
==========================================
- Coverage 94.40% 94.37% -0.04%
==========================================
Files 100 100
Lines 10740 10749 +9
Branches 1214 1215 +1
==========================================
+ Hits 10139 10144 +5
- Misses 536 539 +3
- Partials 65 66 +1
Continue to review full report at Codecov.
|
patkivikram
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #221
This PR introduces two changes to avoid processing of events fetched before a rebalance:
consumer.stop_flowis calledgeneration_idtoMessageto support skipping events with a generation_id not matching the current generation_id.