Avoid crash in recovery by pessimistically looking up the earliest key #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cherry picked the flake8 fixes from #288 to allow CI to pass. |
Codecov Report
@@ Coverage Diff @@
## master #289 +/- ##
=======================================
Coverage 94.70% 94.70%
=======================================
Files 100 100
Lines 10852 10852
Branches 1518 1518
=======================================
Hits 10277 10277
Misses 501 501
Partials 74 74 Continue to review full report at Codecov.
|
cbrand
force-pushed
the
fix/build-offsets-key-error
branch
from
92d415f
to
221689f
Compare
The earliest_offset function in the consumer seems to not always return all tps which have been passed in but presumabely only the ones it has data for. After longer runtime it seems that the response MAY return a dict not filled with all topic partitions which have been added. To bypass this and not lead faust to crash, use the .get function on the returned mapping and default to None on return.
cbrand
force-pushed
the
fix/build-offsets-key-error
branch
from
e2ffde0
to
f26ece8
Compare
patkivikram
approved these changes
Mar 28, 2022
…offsets-key-error
…offsets-key-error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The earliest_offset function in the consumer seems to not always return all tps which have been passed in but presumabely only the ones it has data for.
After longer runtime it seems that the response MAY return a dict not filled with all topic partitions which have been added. To bypass this and not lead faust to crash, use the .get function on the returned mapping and default to None on return.
I think this error occurs if the request happens during a rebalance looking at the code base of aiokafka, but am not totally sure. This change should however not crash the overall recovery process if this occurs. If a rebalance happens on the next call the recovery will restart but will not hard crash as it does right now.
There also seems to be an old issue which I address in this PR:
(Fixes #73)