Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SCRAM-SHA-256/512 SASL Mechanisms available. #29

Merged
merged 1 commit into from
Nov 13, 2020

Conversation

forsberg
Copy link
Contributor

Fixes robinhood/faust#601.

Description

Please describe your pull request.

Makes SCRAM-SHA-256/SCRAM-SHA-512 SASL Mechanisms available.

Tested against a Kafka 2.5.0 cluster with success.

@codecov-io
Copy link

codecov-io commented Nov 13, 2020

Codecov Report

Merging #29 (4d4f675) into master (40237be) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   63.96%   63.96%           
=======================================
  Files          99       99           
  Lines       10272    10272           
  Branches     1153     1153           
=======================================
  Hits         6570     6570           
  Misses       3547     3547           
  Partials      155      155           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40237be...4d4f675. Read the comment docs.

Copy link
Collaborator

@patkivikram patkivikram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to test this using aiokafka==0.7.0 and faust-streaming with your changes?

Copy link
Collaborator

@patkivikram patkivikram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see your comment about testing.

@patkivikram patkivikram merged commit 8c225a8 into faust-streaming:master Nov 13, 2020
@forsberg forsberg deleted the 601-sasl-scram-auth branch November 13, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sasl scram support
3 participants