Minimize standby remaining total calls #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce the calls in the recovery service agent checking if standby remaining totals is done by verifying on the tables if the standbys_ready is already set as this is the only thing which happens in the if statement and is computational cheap compared to iterating constantly over the standby_remaining_totals call.
cbrand
force-pushed
the
feat/slurp-changelogs-checktime-minimize
branch
from
f0b61fe
to
ce8dc5d
Compare
patkivikram
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduce the calls in the recovery service agent checking if standby remaining totals is done by verifying on the tables if the standbys_ready is already set as this is the only thing which happens in the if statement and is computational cheap compared to iterating constantly over the standby_remaining_totals call.
Similar to #291 this should greatly reduce the time spent in the recovery
changelog service task which runs constantly in the background.