Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake warning with bound loop var #326

Merged
merged 2 commits into from Jul 19, 2022

Conversation

wbarnha
Copy link
Member

@wbarnha wbarnha commented Jul 18, 2022

Many PRs were getting this issue:


Run scripts/check
+ isort --check --diff --project=faust faust tests setup.py
+ black --check --diff faust tests setup.py
All done! ✨ 🍰 ✨
342 files would be left unchanged.
+ flake8 faust tests setup.py
tests/bench/base.py:98:65: B023 Function definition does not bind loop variable 'time_1st'.

The goal of this PR is to fix the error.

@patkivikram patkivikram merged commit 1e9d4a5 into faust-streaming:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants