Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(detector): re-implement the cdn-cgi/trace parser #102

Merged
merged 3 commits into from
Nov 15, 2021

Conversation

favonia
Copy link
Owner

@favonia favonia commented Nov 15, 2021

Workaround for #101.

@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #102 (689e9cc) into main (ef50403) will increase coverage by 0.73%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
+ Coverage   78.63%   79.36%   +0.73%     
==========================================
  Files          24       25       +1     
  Lines        1212     1255      +43     
==========================================
+ Hits          953      996      +43     
  Misses        255      255              
  Partials        4        4              
Flag Coverage Δ
unittests 79.36% <100.00%> (+0.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/config/config.go 98.42% <100.00%> (ø)
internal/config/env.go 100.00% <100.00%> (ø)
internal/detector/cloudflare_doh.go 100.00% <100.00%> (ø)
internal/detector/cloudflare_trace.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef50403...689e9cc. Read the comment docs.

@favonia favonia merged commit ebf0639 into main Nov 15, 2021
@favonia favonia deleted the implement-cloudflare-trace branch November 15, 2021 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant