-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Odin inspector 3 not supported (UnityEngine.ExitGUIException) #43
Comments
Issue-Label Bot is automatically applying the label Links: app homepage, dashboard and code for this bot. |
Please provide
|
@Mefodei ODIN related issue, guess you may want to have a look? |
|
## [0.9.4](v0.9.3...v0.9.4) (2020-12-18) ### Bug Fixes * initial null exception error when ODIN is enabled (refs [#43](#43)) ([f8d9bba](f8d9bba))
Hi @tamarillostudio, Sorry for the long delay. I have made a simple change related to ODIN (f8d9bba), but it only affects the initial importer error. I don't have an issue when hit the save button.
Could you give 0.9.4 a try and also upgrade ODIN to 3.0.2? |
Yes, i will try to check this one |
That issue on Odin inspector side. They already fix that in v. 3.0.2 |
@Mefodei thanks for verifying the issue. Issue closed. |
We have a new duplicated new issue #46. I tested with
I still get the same error.
I checked related odin patch notes: https://odininspector.com/patch-notes, since 3.0.2
It seems that we could just ignore the issue.
Thought? |
I can update odin to enable ODIN_INSPECTOR3 [Searchable] attribute support
сб, 15 мая 2021 г. в 15:59, Favo Yang ***@***.***>:
… We have a new duplicated new issue #46
<#46>. I
tested with
- addressables 1.16.19
- odin 3.0.5.0
- importer 0.9.4
I still get the same error.
UnityEngine.ExitGUIException: Exception of type 'UnityEngine.ExitGUIException' was thrown.
I checked related odin patch notes: https://odininspector.com/patch-notes,
since 3.0.2
Fix:
- GUIUtility.ExitGUI() is now called after all button clicks, meaning
that button methods that invalidate the GUI state should no longer cause a
multitude of exceptions related to layout and other GUI states to be thrown
after they're done executing.
It seems that we could just ignore the issue.
public void Draw()
{
try
{
FilterRules(_searchFilter);
_drawerTree.Draw();
ApplyChanges();
}
catch (Exception e)
{
Debug.LogError(e);
}
}
=>
public void Draw()
{
FilterRules(_searchFilter);
_drawerTree.Draw();
ApplyChanges();
}
Thought?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#43 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABY4TDVPFSSO2HY7BFDWNU3TNZV3HANCNFSM4THDTNDQ>
.
--
Best Regards
*Sergey Mikhaylov*
Tel: +7 (931) 963-99-56
CTO
email: ***@***.***
linkedin: https://www.linkedin.com/in/mefodei
github: https://github.com/Mefodei
|
Thanks for the quick reply! Will that fix the issue entirely? Please submit a PR, I would like to test it. I think we can force odin 3 and drop version 2 support. |
Nice, let's drop Odin 2 support. I will create PR
сб, 15 мая 2021 г. в 16:33, Favo Yang ***@***.***>:
… @Mefodei <https://github.com/Mefodei>
Thanks for the quick reply! Will that fix the issue entirely? Please
submit a PR, I would like to test it.
I think we can force odin 3 and drop version 2 support.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#43 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABY4TDW433TJS2VSMABZEHTTNZZ23ANCNFSM4THDTNDQ>
.
--
Best Regards
*Sergey Mikhaylov*
Tel: +7 (931) 963-99-56
CTO
email: ***@***.***
linkedin: https://www.linkedin.com/in/mefodei
github: https://github.com/Mefodei
|
Closed by #53 |
Odin inspector has been updated.
An exception occurs on asset inspector.
The text was updated successfully, but these errors were encountered: