Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(commit-release): remove quotes from commit message template #169

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

RealShadowNova
Copy link
Contributor

@RealShadowNova RealShadowNova commented Apr 23, 2024

Addresses an issue where commits are enclosed in double quotes, which appears to be an oversight introduced in 74c09c7.

I found this bug while releasing one of my packages in RealShadowNova/typedoc-json-parser@3875bbd.

It also appeared to happen in this repository too 88ebba3.

Workaround

You can execute the following command to obtain the expected result. Remember to replace the placeholders with your project-specific values.

cliff-jumper --skip-tag && git commit -m 'your-commit-message' && git tag v1.0.0 && git push && git push --tags && yarn npm publish

Copy link
Member

@favna favna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. I added them because I had them before but I guess they're no longer needed anymore with execa. I guess execa automatically wraps it when it detects the content has spaces.

@favna favna merged commit 9fcab96 into favware:main Apr 23, 2024
6 checks passed
@RealShadowNova RealShadowNova deleted the fix/commit-release branch April 23, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants