test: repo code to cover new lint rules

favware · Jun 13, 2020 · 6831920 · 6831920 · vercel · Jun 13, 2020
1 parent 94f8c63
commit 6831920
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/packages/querystring/__tests__/parse.test.ts b/packages/querystring/__tests__/parse.test.ts
@@ -64,20 +64,19 @@ describe('Standard Behaviour', () => {
 describe('Error checking', () => {
   test('should work with wrong options', () => {
     const expected = { prop: 'value', prop2: 'value2' };
-    // @ts-expect-error
+    // @ts-expect-error This is testing TS-invalid code that is handled in JS
     expect(parse('?prop%value&prop2%value2', { seperator: '&', equals: '%' })).toMatchObject(expected);
   });
 
   test('should error with wrong input', () => {
-    // @ts-expect-error
+    // @ts-expect-error This is testing TS-invalid code that is handled in JS
     expect(() => parse({ prop: 'value', prop2: 'value2' })).toThrowError(
       '@Favware/Querystring: Your input was not an string. Please supply a string when using Parse.'
     );
   });
 
   test('should work when passing invalid separator and equals', () => {
     const expected = { prop: 'value', prop2: 'value2' };
-    // eslint-disable-next-line @typescript-eslint/ban-ts-comment
     // @ts-ignore ts-expect-error doesn't recognize this as a valid usecase yet
     const actual = parse('?prop=value&prop2=value2', { separator: null, equals: null });
     expect(actual).toMatchSnapshot();

diff --git a/packages/querystring/__tests__/stringify.test.ts b/packages/querystring/__tests__/stringify.test.ts
@@ -82,7 +82,7 @@ describe('Error checking', () => {
     const expected = 'prop%value=prop2%value2';
     const actual = stringify(
       { prop: 'value', prop2: 'value2' },
-      // @ts-expect-error
+      // @ts-expect-error This is testing TS-invalid code that is handled in JS
       { separator: '=', equals: '%', includeQeustion: true }
     );
     expect(actual).toMatchSnapshot();
@@ -93,7 +93,6 @@ describe('Error checking', () => {
     const expected = '?propnullvaluenullprop2nullvalue2';
     const actual = stringify(
       { prop: 'value', prop2: 'value2' },
-      // eslint-disable-next-line @typescript-eslint/ban-ts-comment
       // @ts-ignore ts-expect-error doesn't recognize this as a valid usecase yet
       { separator: null, equals: null, includeQuestion: true }
     );