-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for HTML text #55
Comments
Hi @PopJoestar, thanks for those kind words. The idea seems nice. I will think around it and explore a bit. The problem arises with edge cases, like if a user clicks on a link, since its html then what should happen ? If images are there inside then how to handle those ? Or shall we have another lib with webview for react native ? |
I thought we could improve the current renderer to support HTML by passing HTML renderers like https://github.com/meliorence/react-native-render-html through the |
Hi @PopJoestar, with
Thanks for pointing out to this great lib: https://github.com/arendjr/text-clipper |
Hi @fawaz-ahmed , thanks for the tips! I'm already using it in my project with react-native-render-HTML but I haven't tested it yet with your library |
I've tested and shared the sample code. It works great. Thanks @
…________________________________
From: PopJoestar ***@***.***>
Sent: Tuesday, February 22, 2022 5:59:35 PM
To: fawaz-ahmed/react-native-read-more ***@***.***>
Cc: Fawaz Ahmed ***@***.***>; Mention ***@***.***>
Subject: Re: [fawaz-ahmed/react-native-read-more] Adding support for HTML text (Issue #55)
Hi @fawaz-ahmed<https://github.com/fawaz-ahmed> , thanks for the tips! I'm already using it in my project with react-native-render-HTML but I haven't tested it yet with your library
—
Reply to this email directly, view it on GitHub<#55 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AEJEVIDPPKJ2YLUWD53GTULU4OCDPANCNFSM5OGHO5HQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
ITs not showing complete HTML just showing 9 lines without picking html classes |
@saad9624-tribalScale can you share the response you are getting from the |
Yeah, its working after adding width to undefined. |
@fawaz-ahmed I am using the library with expo, works great on mobile devices, for web I am not able to make this work. |
@mohil-nft this package doesn't supports web. It depends on |
Hi, thanks for this great package, I think it will be good if we add support for HTML text, currently I'm using text-clipper in my project.
The text was updated successfully, but these errors were encountered: