Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive lang change, refactor thumbnail selector, not work from 21/07/2022 #137

Merged
merged 2 commits into from
Jul 28, 2022

Conversation

sacredrel1c
Copy link
Contributor

@sacredrel1c sacredrel1c commented Jul 23, 2022

Recursive language change, if YouTube, for some reason, did not change the language the first time, although the English (UK) button was pressed, the exit from the recursion occurs when the selectedLang selector is tested for the set language. And changed selector for choising thumbnail, youtube add at the end.


This change is Reviewable

…e the language the first time, although the English (UK) button was pressed, the exit from the recursion occurs when the selectedLang selector is tested for the set language. And changed selector for choising thumbnail, youtube add at the end.
@fawazahmed0
Copy link
Owner

I have fixed the thumbnail issue in v1.3.66

@sacredrel1c
Copy link
Contributor Author

I have fixed the thumbnail issue in v1.3.66

But you don't fix problem with change lang at first-time. I'm from Ukraine and youtube set default language ukrainian based on my ip, and basically don't change at first-time.

@fawazahmed0
Copy link
Owner

ok, thanks

@fawazahmed0 fawazahmed0 merged commit 6c3d242 into fawazahmed0:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants