Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create customSelectorUrl config option #139

Merged
merged 1 commit into from
Jul 26, 2022
Merged

feat: create customSelectorUrl config option #139

merged 1 commit into from
Jul 26, 2022

Conversation

lhjt
Copy link
Contributor

@lhjt lhjt commented Jul 26, 2022

This new configuration option lets the user decide what URL to look out for once video uploading has been completed.

For my use case, I want the script to detect when a short has been uploaded, which doesn't currently work (the URL generated by youtube starts with https://youtube/shorts rather than https://youtu.be, meaning the processing fails if it cannot find the uploaded short)

0efcaa6389d861f7c1669070d2b1467e50abe51b034d989f04e1bf9e2ba4ba01

This configuration option will allow the search selector to be set by the user in the Video object, like so:

image


This change is Reviewable

@fawazahmed0
Copy link
Owner

Thanks for the PR

@fawazahmed0 fawazahmed0 merged commit 2d9f53f into fawazahmed0:main Jul 26, 2022
@pierreminiggio
Copy link
Contributor

pierreminiggio commented Jul 26, 2022

I opened an issue related to this MR. @lhjt would be apreciated if you could look into it to see if the MR I attached to my issue solves the same problem as you experienced but without the need for a config'.
#141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants