Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Daily Limit Check Timeout #160

Closed
wants to merge 1 commit into from
Closed

Fix Daily Limit Check Timeout #160

wants to merge 1 commit into from

Conversation

TiagoSeverino
Copy link
Contributor

@TiagoSeverino TiagoSeverino commented Aug 25, 2022 •
edited by fawazahmed0

This change is Reviewable

@TiagoSeverino
Copy link
Contributor Author

500ms is not enought to get the daily limit message, at least on my machine.
Usually takes 3s

@fawazahmed0
Copy link
Owner

fawazahmed0 commented Aug 28, 2022 •
edited

Increasing the seconds will conflict with this and it will cause whole program to stop indefinitely.
There needs to be better way handle this
Also see this

@fawazahmed0
Copy link
Owner

PR #163 seems to add a better way of handling this thing

@fawazahmed0
Copy link
Owner

fawazahmed0 commented Sep 19, 2022 •
edited

Thanks for your PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TiagoSeverino @fawazahmed0