Fixed issue where uploading would result in Show More being toggled incorrectly… #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly pressed Fixed issue where uploading would result in Show More being incorrectly pressed Exact error: TypeError: Cannot read properties of undefined (reading 'click') Reasoning is that Show More would be toggled twice resulting in elements not existing when they need to.
|
Please note that I did comment out the code on LN224 that toggles the button before adding playlists, there should be no reason for it to be called, but in the case that there is a reason for let me know and I can edit my commit. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue where uploading would result in Show More being toggled incorrectly…
Exact error: TypeError: Cannot read properties of undefined (reading 'click')
Reasoning is that Show More would be toggled twice resulting in elements not existing when they need to.
The fix is to ensure that the elements that are added as a result of pressing show more exist before proceeding with the code execution. In other words: Check if elements exist, if not press Show More, wait 1 second, check if everything exists. Proceed if everything is there.
This change is