Added support for selecting "Gaming" category aswell as game. #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed "gameTitle" to "gameTitleSearch" to better reflect intent
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support to upload/edit a video and set it's category to gaming, and select a game.
The Video and VideoToEdit interfaces get 2 extra options, one for what to search under the gaming category, and a predicate for choosing a category out of the results, the predicate is also optional, and if null is passed the selector will just take the first valid choice.
I'd recommend trying the modification locally yourself to ensure there are no issues.
I also split the game chooser into it's own function as the code is used in editing a video and uploading but there is no UI differance. I have not tried with the edit function only upload, but I got the selectors using the edit panel.
The options I have tested with:
gameTitleSearch: "Sea of Thieves" gameSelector: async ( data: GameData ) => data.title == "Tide of Thieves"That chose "Tide of Thieves".
gameTitleSearch: "Sea of Thieves"That chose "Sea of Thieves".
I have also tested without specifying anything.
Everything works for me and hopefully you like this addition.
Also, is there a reason for there not being a way to choose if the video should be public, private or unlisted on upload?
This change is