Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding comment() function #58

Merged
merged 11 commits into from
Nov 4, 2021
Merged

Conversation

TentacleSama4254
Copy link
Contributor

@TentacleSama4254 TentacleSama4254 commented Nov 4, 2021

This feature isn't related to uploading videos but I thought since we're already logged into YouTube this would be cool

import {comment} from 'youtube-videos-uploader' 
  • comments for normal videos

  • YouTube liveChat comment

  • need to handle errors when comments disabled


This change is Reviewable

@fawazahmed0
Copy link
Owner

I tested it, but it is not working for me

Session has been loaded in the browser
{
  link: 'https://www.youtube.com/watch?v=PF_oKrvMX2M',
  text: 'comment 1'
}
[
  {
    err: true,
    data: TypeError: Cannot read property 'substring' of undefined
        at C:\Users\nawaz\Documents\GitHub\youtube-uploader\dist\upload.js:301:38
        at Generator.next (<anonymous>)
        at fulfilled (C:\Users\nawaz\Documents\GitHub\youtube-uploader\dist\upload.js:5:58)
        at processTicksAndRejections (node:internal/process/task_queues:94:5)
  }
]

@fawazahmed0
Copy link
Owner

Everything is working fine

@fawazahmed0 fawazahmed0 merged commit a53c949 into fawazahmed0:main Nov 4, 2021
@TentacleSama4254
Copy link
Contributor Author

TentacleSama4254 commented Nov 4, 2021

I tested it, but it is not working for me

Session has been loaded in the browser
{
  link: 'https://www.youtube.com/watch?v=PF_oKrvMX2M',
  text: 'comment 1'
}
[
  {
    err: true,
    data: TypeError: Cannot read property 'substring' of undefined
        at C:\Users\nawaz\Documents\GitHub\youtube-uploader\dist\upload.js:301:38
        at Generator.next (<anonymous>)
        at fulfilled (C:\Users\nawaz\Documents\GitHub\youtube-uploader\dist\upload.js:5:58)
        at processTicksAndRejections (node:internal/process/task_queues:94:5)
  }
]

Oh probably because I used the property comment: instead of text: in my code, you can change that if you like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants