Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the faye engine doc to reflect implementation. #513

Closed
wants to merge 1 commit into from
Closed

Update the faye engine doc to reflect implementation. #513

wants to merge 1 commit into from

Conversation

viktomas
Copy link
Contributor

@jcoglan
Copy link
Collaborator

jcoglan commented Feb 14, 2020

This does not look accurate to me.

First, the core faye package does not depend on this interface; it actually doesn't currently depend on the engine API supporting callbacks at all; these were added for forwards compatibility as we may need to add more detail to this interface.

Second, it doesn't describe the implementation. The memory engine returns a single argument to the callback (true) and the redis engine returns no arguments at all. Both do support passing a context argument but I don't want this to be a requirement of the interface definition.

Do you have some more context on why you made this documentation change?

@viktomas viktomas closed this by deleting the head repository Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants